gio: change write_all/read_all error return type to carry partial count#1981
Open
mvanhorn wants to merge 1 commit into
Open
gio: change write_all/read_all error return type to carry partial count#1981mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
sdroege
approved these changes
Jun 8, 2026
Member
|
Test failures need some fixes. |
Member
|
@mvanhorn Do you want to update this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the return type of
OutputStream::write_all_async/write_all_futureand the symmetricInputStream::read_all_async/read_all_future/read_allfromResult<(B, usize, Option<glib::Error>), (B, glib::Error)>toResult<(B, usize), (B, usize, glib::Error)>, so callers no longer inspect an innerOptionon theOkpath and the error path carries the partial byte count.Why this matters
The old
Ok-with-Some(error)shape forced every caller to check the innerOptioneven on success, which is confusing and easy to get wrong (#1942). @sdroege agreed the design is wrong and stated the preferred variantResult<(B, usize), (B, usize, glib::Error)>, which also surfaces the partial count on failure. Each async trampoline now buildsOk((buffer, bytes_written))when no error occurred andErr((buffer, bytes_written, ...))otherwise, dropping the prior three-state branch. The*_futurewrappers mirror the new callback type and the syncread_allsurfaces the error directly.This is a breaking API change, appropriate for the in-progress
0.23.0-alphacycle.Testing
read_allandwrite_all.Closes #1942